On Thu, Jun 30, 2011 at 04:28:14PM -0700, Dan Magenheimer wrote:
> Hi Dan --
>
> Thanks for the careful review. You're right... some
> of this was leftover from debugging an off-by-one error,
> though the code as is still works.
>
> OTOH, there's a good chance that much of this sysfs
> code will disappear before zcache would get promoted
> out of staging, since it is to help those experimenting
> with zcache to get more insight into what the underlying
> compression/accept-reject algorithms are doing.
>
> So I hope you (and GregKH) are OK that another version is
> not necessary at this time to fix these.
Off by one errors are kind of insidious. People cut and paste them
and they spread. If someone adds a new list of chunks then there
are now two examples that are correct and two which have an extra
element, so it's 50/50 that he'll copy the right one.
Btw, looking at it again, this seems like maybe a similar issue in
zbud_evict_zbpg():
515 /* now try freeing unbuddied pages, starting with least space avail */
516 for (i = 0; i < MAX_CHUNK; i++) {
517 retry_unbud_list_i:
MAX_CHUNKS is NCHUNKS - 1. Shouldn't that be i < NCHUNKS so that we
reach the last element in the list?
regards,
dan carpenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>