On 06/18/2020 02:26 PM, Mike Rapoport wrote: > On Thu, Jun 18, 2020 at 06:45:27AM +0530, Anshuman Khandual wrote: >> This series enables vmemmap backing memory allocation from device memory >> ranges on arm64. But before that, it enables vmemmap_populate_basepages() >> and vmemmap_alloc_block_buf() to accommodate struct vmem_altmap based >> alocation requests. >> >> This series applies on 5.8-rc1. >> >> Pending Question: >> >> altmap_alloc_block_buf() does not have any other remaining users in >> the tree after this change. Should it be converted into a static >> function and it's declaration be dropped from the header >> (include/linux/mm.h). Avoided doing so because I was not sure if there >> are any off-tree users or not. > > Well, off-tree users probably have an active fork anyway so they could > switch to vmemmap_alloc_block_buf()... Sure, will make the function a static and remove it's declaration from the header. > > Regardless, can you please update Documentation/vm/memory-model.rst to > keep it in sync with the code? Sure, will do.
