On Tue, 2011-06-28 at 10:02 -0700, Linus Torvalds wrote: > On Tue, Jun 28, 2011 at 9:47 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > + * Note: if @flags has FAULT_FLAG_ALLOW_RETRY set then the mmap_sem > > + * may be released if it failed to arquire the page_lock. If the > > + * mmap_sem is released then it will return VM_FAULT_RETRY set. > > + * This is to keep the time mmap_sem is held when the page_lock > > + * is taken for IO. > > So I know what that flag does, but I knew it without the comment. > > WITH the comment, I'm just confused. "This is to keep the time > mmap_sem is held when the page_lock is taken for IO." > > Sounds like a google translation from swahili. "keep the time" what? "When people ask me what language is my mother tongue, I simply reply C" Google translate from C -> english is worse than swahily -> english :p > > Maybe "keep" -> "minimize"? Or just "This is to avoid holding mmap_sem > while waiting for IO" OK, that sounds better. Thanks. I'll go to cut a v2, but I'll wait a day or so for others to comment. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>