On Wed 27-05-20 15:44:59, Joonsoo Kim wrote: > From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > To prepare unifying duplicated functions in following patches, this patch > changes the interface of the migration target alloc/free functions. > Functions now use struct alloc_control as an argument. It also pulls private argument into alloc_control and keeps it that way. Wouldn't it be better to use explicit types and names in a union? Each allocation callback has to understant the meaning anyway. I would consider the resulting code cleaner that way. What do you think? -- Michal Hocko SUSE Labs
