On 6/6/20 5:12 PM, Matthew Wilcox wrote: > On Sat, Jun 06, 2020 at 01:38:57AM -0600, Chris Murphy wrote: >> [ 5225.501756] gnome-shell: page allocation failure: order:0, >> mode:0x400d0(__GFP_IO|__GFP_FS|__GFP_COMP|__GFP_RECLAIMABLE), >> nodemask=(null),cpuset=/,mems_allowed=0 > > These are relatively liberal constraints on what the page allocator is > allowed to do in order to succeed. They are not, it's not allowed to reclaim at all - __GFP_RECLAIMABLE is not the same thing as __GFP_RECLAIM :) AFAICS the masks starts in shmem_gfp_pages() * Fail silently without starting the shrinker noreclaim = mapping_gfp_constraint(mapping, ~__GFP_RECLAIM); noreclaim |= __GFP_NORETRY | __GFP_NOWARN; possibly mapping has GFP_KERNEL, but this removes the GFP_RECLAIM part and adds __GFP_NORETRY | __GFP_NOWARN if this fails (silently) there's a fallback But when this reaches __read_swap_cache_async() it does: /* May fail (-ENOMEM) if XArray node allocation failed. */ err = add_to_swap_cache(new_page, entry, gfp_mask & GFP_KERNEL); So we lose the __GFP_NORETRY and importantly __GFP_NOWARN. Looks like you added that with commit 8d93b41c09d1b :) ... >> [ 5225.502339] Mem-Info: >> [ 5225.502345] active_anon:1433763 inactive_anon:207289 isolated_anon:182 >> active_file:10333 inactive_file:8393 isolated_file:2 >> unevictable:4657 dirty:100 writeback:0 unstable:0 >> slab_reclaimable:16672 slab_unreclaimable:38093 >> mapped:8919 shmem:4496 pagetables:10454 bounce:0 >> free:26161 free_pcp:2054 free_cma:0 >> [ 5225.502350] Node 0 active_anon:5735052kB inactive_anon:829156kB >> active_file:41332kB inactive_file:33572kB unevictable:18628kB >> isolated(anon):728kB isolated(file):8kB mapped:35676kB dirty:400kB >> writeback:0kB shmem:17984kB shmem_thp: 0kB shmem_pmdmapped: 0kB >> anon_thp: 0kB writeback_tmp:0kB unstable:0kB all_unreclaimable? no >> [ 5225.502352] Node 0 DMA free:15344kB min:128kB low:160kB high:192kB >> reserved_highatomic:0KB active_anon:0kB inactive_anon:0kB >> active_file:0kB inactive_file:0kB unevictable:0kB writepending:0kB >> present:15988kB managed:15360kB mlocked:0kB kernel_stack:0kB >> pagetables:0kB bounce:0kB free_pcp:0kB local_pcp:0kB free_cma:0kB >> [ 5225.502357] lowmem_reserve[]: 0 2069 7810 7810 7810 >> [ 5225.502360] Node 0 DMA32 free:40212kB min:17868kB low:22332kB >> high:26796kB reserved_highatomic:0KB active_anon:1640016kB >> inactive_anon:265148kB active_file:9856kB inactive_file:12584kB >> unevictable:2968kB writepending:136kB present:2255864kB >> managed:2157904kB mlocked:0kB kernel_stack:48kB pagetables:8524kB >> bounce:0kB free_pcp:2904kB local_pcp:156kB free_cma:0kB >> [ 5225.502365] lowmem_reserve[]: 0 0 5741 5741 5741 >> [ 5225.502368] Node 0 Normal free:49088kB min:49584kB low:61980kB >> high:74376kB reserved_highatomic:2048KB active_anon:4098076kB >> inactive_anon:563004kB active_file:32212kB inactive_file:21312kB >> unevictable:13680kB writepending:0kB present:6027264kB >> managed:5879476kB mlocked:1792kB kernel_stack:7312kB >> pagetables:33292kB bounce:0kB free_pcp:5388kB local_pcp:780kB >> free_cma:0kB >> [ 5225.502373] lowmem_reserve[]: 0 0 0 0 0 >> [ 5225.502376] Node 0 DMA: 0*4kB 0*8kB 1*16kB (U) 1*32kB (U) 1*64kB >> (U) 1*128kB (U) 1*256kB (U) 1*512kB (U) 0*1024kB 1*2048kB (M) 3*4096kB >> (M) = 15344kB >> [ 5225.502385] Node 0 DMA32: 1160*4kB (UM) 471*8kB (UME) 84*16kB (UM) >> 103*32kB (UME) 116*64kB (UME) 59*128kB (UME) 26*256kB (UE) 8*512kB (E) >> 2*1024kB (E) 0*2048kB 0*4096kB = 40824kB >> [ 5225.502394] Node 0 Normal: 4778*4kB (UMH) 1400*8kB (UMEH) 346*16kB >> (UMH) 270*32kB (UMEH) 20*64kB (UMEH) 20*128kB (MEH) 4*256kB (MEH) >> 0*512kB 0*1024kB 0*2048kB 0*4096kB = 49352kB > > Umm ... seems like there's lots of memory free. Why did this fail? Normal is below min watermark, and for DMA32 and DMA the lowmem reserve most likely kicked in.