Re: [patch 004/131] mm/gup: refactor and de-duplicate gup_fast() code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 3, 2020 at 7:19 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Now it uses FOLL_WRITE (because that's what
> internal_get_user_pages_fast() does), which will disallow read-only
> pages (in order to handle them properly for COW in the slow path), and
> then the fact that the slow-path is entirely disabled for this case
> means that it doesn't work at all.

I have tried to fix it up, partly by editing the patches directly, and
partly by then trying to fix up comments after-the-fact.

The end result looks possibly correct after it all. But it would have
been easier had I just had a merge conflict to deal with, rather than
trying to fix up patches.

Will do more testing etc before really merging and then pushing out.

              Linus




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux