On 6/1/20 5:00 PM, Agarwal, Anchal wrote: > > > I don't see these last two used anywhere. Are you, in fact, > distinguishing between PM suspend and hibernation? > > Yes, I am. Unless there is a better way to distinguish at runtime which I haven't figured out yet. > The initial design was to have separate states for separate modes. Currently, PM_HIBERNATION is handled > by !xen_suspend . However, if any case arises where we need to set the suspend_mode, its available via > this interface. This is basically to support PM* ops via ACPI path. Since, PM_SUSPEND is not handled by the series > the code piece can be removed and added later. Any comments? Yes, if this is not being handled then I don't see any reason for this code to be there. -boris
