On 6/1/20 8:43 AM, Sedat Dilek wrote: > On Mon, Jun 1, 2020 at 4:35 PM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 6/1/20 8:14 AM, Jens Axboe wrote: >>> On 6/1/20 8:13 AM, Sedat Dilek wrote: >>>> On Mon, Jun 1, 2020 at 4:04 PM Jens Axboe <axboe@xxxxxxxxx> wrote: >>>>> >>>>> On 6/1/20 7:35 AM, Sedat Dilek wrote: >>>>>> Hi Jens, >>>>>> >>>>>> with Linux v5.7 final I switched to linux-block.git/for-next and reverted... >>>>>> >>>>>> "block: read-ahead submission should imply no-wait as well" >>>>>> >>>>>> ...and see no boot-slowdowns. >>>>> >>>>> Can you try with these patches applied instead? Or pull my async-readahead >>>>> branch from the same location. >>>>> >>>> >>>> Yes, I can do that. >>>> I pulled from linux-block.git#async-readahead and will report later. >>>> >>>> Any specific testing desired by you? >>> >>> Just do your boot timing test and see if it works, thanks. >> >> Actually, can you just re-test with the current async-buffered.6 branch? >> I think the major surgery should wait for 5.9, we can do this a bit >> easier without having to touch everything around us. >> > > With linux-block.git#async-readahead: > > mycompiler -Wp,-MD,kernel/.sys.o.d -nostdinc -isystem > /home/dileks/src/llvm-toolchain/install/lib/clang/10.0.1rc1/include > -I./arch/x86/include -I./arch/x86/include/generated -I./include > -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi > -I./include/uapi -I./include/generated/uapi -include > ./include/linux/kconfig.h -include ./include/linux/compiler_types.h > -D__KERNEL__ -Qunused-arguments -Wall -Wundef > -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing > -fno-common -fshort-wchar -fno-PIE > -Werror=implicit-function-declaration -Werror=implicit-int > -Wno-format-security -std=gnu89 -no-integrated-as > -Werror=unknown-warning-option -mno-sse -mno-mmx -mno-sse2 -mno-3dnow > -mno-avx -m64 -mno-80387 -mstack-alignment=8 -mtune=generic > -mno-red-zone -mcmodel=kernel -Wno-sign-compare > -fno-asynchronous-unwind-tables -mretpoline-external-thunk > -fno-delete-null-pointer-checks -Wno-address-of-packed-member -O2 > -Wframe-larger-than=2048 -fstack-protector-strong > -Wno-format-invalid-specifier -Wno-gnu -mno-global-merge > -Wno-unused-const-variable -g -gz=zlib -pg -mfentry -DCC_USING_FENTRY > -Wdeclaration-after-statement -Wvla -Wno-pointer-sign > -Wno-array-bounds -fno-strict-overflow -fno-merge-all-constants > -fno-stack-check -Werror=date-time -Werror=incompatible-pointer-types > -fmacro-prefix-map=./= -fcf-protection=none -Wno-initializer-overrides > -Wno-format -Wno-sign-compare -Wno-format-zero-length > -Wno-tautological-constant-out-of-range-compare > -DKBUILD_MODFILE='"kernel/sys"' -DKBUILD_BASENAME='"sys"' > -DKBUILD_MODNAME='"sys"' -c -o kernel/sys.o kernel/sys.c > fs/9p/vfs_addr.c:112:4: error: use of undeclared identifier 'filp' > filp->private_data); > ^ > 1 error generated. > make[5]: *** [scripts/Makefile.build:267: fs/9p/vfs_addr.o] Error 1 > make[4]: *** [scripts/Makefile.build:488: fs/9p] Error 2 > make[3]: *** [Makefile:1735: fs] Error 2 > make[3]: *** Waiting for unfinished jobs.... > > I guess block.git#async-buffered.6 needs the same revert of "block: > read-ahead submission should imply no-wait as well". Sorry, forgot to push out the updated version. But as per previous email, I think that major work should wait. Just try the updated async-buffered.6 branch instead. -- Jens Axboe
