> On May 29, 2020, at 6:32 AM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > We no longer return 0 here and the comment doesn't tell us anything > that we don't already know (SIGBUS is a pretty good indicator that > things didn't work out). > > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > --- > mm/filemap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 23a051a7ef0f..fe079e9219d1 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) > if (!error || error == AOP_TRUNCATED_PAGE) > goto retry_find; > > - /* Things didn't work out. Return zero to tell the mm layer so. */ > shrink_readahead_size_eio(ra); > return VM_FAULT_SIGBUS; Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>
