2020년 5월 21일 (목) 오전 9:43, Roman Gushchin <guro@xxxxxx>님이 작성: > > On Mon, May 18, 2020 at 10:20:49AM +0900, js1304@xxxxxxxxx wrote: > > From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > > > Currently, page allocation functions for migration requires some arguments. > > More worse, in the following patch, more argument will be needed to unify > > the similar functions. To simplify them, in this patch, unified data > > structure that controls allocation behaviour is introduced. > > Is it all about huge pages only? If so, maybe adding huge_page suffix/prefix > to struct alloc_control? E.g. huge_alloc_control or something like this. No, it will be used for other migration target allocation functions. You can see it on following patches. > > > > For clean-up, function declarations are re-ordered. > > > > Note that, gfp_mask handling on alloc_huge_page_(node|nodemask) is > > slightly changed, from ASSIGN to OR. It's safe since caller of these > > functions doesn't pass extra gfp_mask except htlb_alloc_mask(). > > Changes make sense to me, but it feels like this patch is doing several > thing simultaneously. Do you mind splitting it into few? I will try to split it on next spin. Thanks.
