Re: [PATCH mm v4 3/4] mm: move cgroup high memory limit setting into struct page_counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 19 May 2020 15:15:41 -0700 Shakeel Butt wrote:
> > --- a/mm/page_counter.c
> > +++ b/mm/page_counter.c
> > @@ -198,6 +198,11 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages)
> >         }
> >  }
> >
> > +void page_counter_set_high(struct page_counter *counter, unsigned long nr_pages)
> > +{
> > +       WRITE_ONCE(counter->high, nr_pages);
> > +}
> > +  
> 
> Any reason not to make this static inline like
> page_counter_is_above_high() and in page_counter.h?

My reason was consistency with other page_counter_set_xyz() helpers,
but obviously happy to change if needed...




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux