Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 2011年06月22日 11:24, David Rientjes 写道:
On Wed, 22 Jun 2011, Cong Wang wrote:

Introduce "transparent_hugepage=0" to totally disable THP.
"transparent_hugepage=never" means setting THP to be partially
disabled, we need a new way to totally disable it.


Why can't you just compile it off so you never even compile
mm/huge_memory.c in the first place and save the space in the kernel image
as well?  Having the interface available to enable the feature at runtime
is worth the savings this patch provides, in my opinion.

https://lkml.org/lkml/2011/6/20/506


If you're proposing a patch for a specific purpose, it's appropriate to
include that in the changelog.

Sorry, I can't put everything you don't see into the changelog.


But now that I know what you're proposing this for, it's an easy NACK:
transparent_hugepage=0 has no significant benefit over
transparent_hugepage=never for kdump because the memory savings is
negligible.

I hate to repeat things, sorry, please go for the other thread where I
replied to Andrea.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]