On 06/21/2011 12:08 AM, Cong Wang wrote:
The thing is that we can save ~10K by adding 3 lines of code as this patch showed, where else in kernel can you save 10K by 3 lines of code? (except some kfree() cases, of course) So, again, why not have it? ;)
Because we'll end up with hundreds of lines of code, just to save under 1MB of memory. Which ends up not being saved at all, because people will still give their kdump kernel 128MB :) The only really big gain you are likely to get is making sure all the per-cpu memory is not allocated in the kdump kernel (which is booted with 1 cpu). That is a big, multi-MB, optimization that can be implemented in one place. Large savings for a localized change, so you actually have a chance of having the changes accepted upstream. -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>