This "goto" doesn't reduce any code, but bother the readers. Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> --- mm/page_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 76965be1d40e..19d429abb2cc 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -237,8 +237,7 @@ int generic_swapfile_activate(struct swap_info_struct *sis, return ret; bad_bmap: pr_err("swapon: swapfile has holes\n"); - ret = -EINVAL; - goto out; + return -EINVAL; } /* -- 2.26.0.106.g9fadedd