Re: [PATCH 3/3] mm: print information when THP is disabled automatically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 2011年06月21日 01:01, Mel Gorman 写道:
On Tue, Jun 21, 2011 at 12:34:30AM +0800, Amerigo Wang wrote:
Print information when THP is disabled automatically so that
users can find this info in dmesg.

Signed-off-by: WANG Cong<amwang@xxxxxxxxxx>
---
  mm/huge_memory.c |    5 ++++-
  1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 7fb44cc..07679da 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -544,8 +544,11 @@ static int __init hugepage_init(void)
  	 * where the extra memory used could hurt more than TLB overhead
  	 * is likely to save.  The admin can still enable it through /sys.
  	 */
-	if (totalram_pages<  (CONFIG_TRANSPARENT_HUGEPAGE_THRESHOLD<<  (20 - PAGE_SHIFT)))
+	if (totalram_pages<  (CONFIG_TRANSPARENT_HUGEPAGE_THRESHOLD
+					<<  (20 - PAGE_SHIFT))) {
+		printk(KERN_INFO "hugepage: disabled auotmatically\n");
  		transparent_hugepage_flags = 0;
+	}

  	start_khugepaged();


Guess this doesn't hurt. You misspelled automatically though and
mentioning "hugepage" could be confused with hugetlbfs.


Yeah, sorry for the typo.

But, there are many printk messages in the same file start with "hugepage:".
:-) I can send a patch to replace all of them with "THP" if you want...

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]