On Wed, 6 May 2020 10:18:24 +0800 Walter Wu <walter-zh.wu@xxxxxxxxxxxx> wrote: > On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote: > > On 4/20/20 6:35 PM, Walter Wu wrote: > > > Modify the variable type of 'skip' member of struct stack_trace. > > > In theory, the 'skip' variable type should be unsigned int. > > > There are two reasons: > > > - The 'skip' only has two situation, 1)Positive value, 2)Zero > > > - The 'skip' of struct stack_trace has inconsistent type with struct > > > stack_trace_data, it makes a bit confusion in the relationship between > > > struct stack_trace and stack_trace_data. > > > > Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx> > > Hi Andrew, > > Would you know why not to be picked up this patch yet? > Do I miss somethings? I'd decided to pass on this because it's so minor. We inappropriately use signed types in soooo many places :(
