On Wed, May 6, 2020 at 8:15 AM Roman Gushchin <guro@xxxxxx> wrote:
>
> On Wed, May 06, 2020 at 07:34:16AM -0700, Shakeel Butt wrote:
> > Hi Roman,
> >
> > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added
> > the memcg reclaim stats. However for the global PGSCAN and PGSTEAL
> > counters it restricts them to be updated only for global reclaim while
> > the PGREFILL global counter is updated for both global and cgroup
> > reclaim. Is that intentional?
>
> Hello, Shakeel!
>
> It looks like it was so long before 2262185c5b28. And I don't know any
> particular reason for it. I guess it was unintentional.
>
Indeed it was done in 904249aa6801 ("mm: fix up the vmscan stat in
vmstat"). I think we should make them consistent. I will see if these
global reclaim checks should be removed.
thanks,
Shakeel
