(2011/06/02 16:00), Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Іt is impossible to understand what the shrinkers are actually doing > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > --- > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++ > mm/vmscan.c | 6 +++- > 2 files changed, 72 insertions(+), 1 deletions(-) This look good to me. I have two minor request. 1) please change patch order, move this patch after shrinker changes. iow, now both this and [2/12] have tracepoint change. I don't like it. 2) please avoid cryptic abbreviated variable names. Instead, please just use the same variable name with vmscan.c source code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>