Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greetings;

I recently noticed this change via the linux-next tree.

It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice.

Many thanks.

John Dorminy



On Tue, Apr 14, 2020 at 11:15 AM Wei Liu <wei.liu@xxxxxxxxxx> wrote:
On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote:
> The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove
> it.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx> [hyperv]
> Acked-by: Gao Xiang <xiang@xxxxxxxxxx> [erofs]
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
>  arch/x86/hyperv/hv_init.c              |  3 +--
[...]
>
> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
> index 5a4b363ba67b..a3d689dfc745 100644
> --- a/arch/x86/hyperv/hv_init.c
> +++ b/arch/x86/hyperv/hv_init.c
> @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu)
>        * not be stopped in the case of CPU offlining and the VM will hang.
>        */
>       if (!*hvp) {
> -             *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO,
> -                              PAGE_KERNEL);
> +             *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO);
>       }

Acked-by: Wei Liu <wei.liu@xxxxxxxxxx>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux