Hi Scott, I love your patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on next-20200421] [cannot apply to char-misc/char-misc-testing kselftest/next linus/master v5.7-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200422-114528 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 55623260bb33e2ab849af76edf2253bc04cb241f config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/misc/bcm-vk/bcm_vk_dev.c: In function 'bcm_vk_sync_card_info': >> drivers/misc/bcm-vk/bcm_vk_dev.c:329:31: warning: right shift count >= width of type [-Wshift-count-overflow] vkwrite32(vk, vk->tdma_addr >> 32, BAR_1, ^~ drivers/misc/bcm-vk/bcm_vk_dev.c: In function 'bcm_vk_buf_notify': drivers/misc/bcm-vk/bcm_vk_dev.c:377:30: warning: right shift count >= width of type [-Wshift-count-overflow] vkwrite32(vk, host_buf_addr >> 32, BAR_1, ^~ vim +329 drivers/misc/bcm-vk/bcm_vk_dev.c 314 315 static int bcm_vk_sync_card_info(struct bcm_vk *vk) 316 { 317 uint32_t rdy_marker = vkread32(vk, BAR_1, VK_BAR1_MSGQ_DEF_RDY); 318 319 /* check for marker, but allow diags mode to skip sync */ 320 if (!bcm_vk_msgq_marker_valid(vk)) 321 return (rdy_marker == VK_BAR1_DIAG_RDY_MARKER ? 0 : -EINVAL); 322 323 /* 324 * Write down scratch addr which is used for DMA. For 325 * signed part, BAR1 is accessible only after boot2 has come 326 * up 327 */ 328 if (vk->tdma_addr) { > 329 vkwrite32(vk, vk->tdma_addr >> 32, BAR_1, 330 VK_BAR1_SCRATCH_OFF_LO); 331 vkwrite32(vk, (uint32_t)vk->tdma_addr, BAR_1, 332 VK_BAR1_SCRATCH_OFF_HI); 333 vkwrite32(vk, nr_scratch_pages * PAGE_SIZE, BAR_1, 334 VK_BAR1_SCRATCH_SZ_ADDR); 335 } 336 337 /* get static card info, only need to read once */ 338 bcm_vk_get_card_info(vk); 339 340 return 0; 341 } 342 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
