Re: [PATCH 2/8] fs: extract simple_pin/release_fs to separate files

[Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>]

On 4/21/20 1:19 PM, Frederic Barrat wrote:
> > diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kconfig
> > index 39eec9031487..a62795079d9c 100644
> > --- a/drivers/misc/cxl/Kconfig
> > +++ b/drivers/misc/cxl/Kconfig
> > @@ -19,6 +19,7 @@ config CXL
> >       select CXL_BASE
> >       select CXL_AFU_DRIVER_OPS
> >       select CXL_LIB
> > +    select SIMPLEFS
> >       default m
> >       help
> >         Select this option to enable driver support for IBM Coherent
> > diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
> > index b493de962153..0b8f8de7475a 100644
> > --- a/drivers/misc/cxl/api.c
> > +++ b/drivers/misc/cxl/api.c
> > @@ -9,6 +9,7 @@
> >   #include <misc/cxl.h>
> >   #include <linux/module.h>
> >   #include <linux/mount.h>
> > +#include <linux/simplefs.h>
> >   #include <linux/pseudo_fs.h>
> >   #include <linux/sched/mm.h>
> >   #include <linux/mmu_context.h>
> > diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig
> > index 2d2266c1439e..ddd9245fff3d 100644
> > --- a/drivers/misc/ocxl/Kconfig
> > +++ b/drivers/misc/ocxl/Kconfig
> > @@ -12,6 +12,7 @@ config OCXL
> >       depends on PPC_POWERNV && PCI && EEH
> >       select OCXL_BASE
> >       select HOTPLUG_PCI_POWERNV
> > +    select SIMPLEFS
>
>
> It's not clear to me the Kconfig updated is needed for the ocxl driver. 
> I think it's only needed for the cxl driver.

I am going to get rid of the separate simplefs.c file and related 
Kconfig entry and put everything in fs/libfs.c, so this file (together 
with many others touched in this patch) won't be modified in v2.

Thanks,

Emanuele