On Fri, 17 Apr 2020 18:56:51 -0700 Dongli Zhang <dongli.zhang@xxxxxxxxxx> wrote:
> > @@ -2096,6 +2097,7 @@ static void deactivate_slab(struct kmem_
> > slab_fix(s, "Isolate corrupted freechain");
> > break;
> > }
> > +#endif
> >
> > do {
> > prior = page->freelist;
> >
> > But it's a bit ugly. How about this?
>
> Sorry that I did not realize check_valid_pointer() requires CONFIG_SLAB_DEBUG.
>
> Yes, it is much better to encapsulate it into freelist_corrupted() and just
> return false when CONFIG_SLAB_DEBUG is not involved. The check_object() has
> similar implementation.
>
> Should I resend with your "Signed-off-by" or you would just fix it when applying?
That's OK. I'll fold the patches together and update the changelog
before sending the patch in to Linus.
