On Thu, 2020-04-16 at 19:53 +0200, David Hildenbrand wrote: > > > > > > > Hm, I'm happy to make the changes, but EINVAL to me suggests there is a > > > problem in the way this was called by the user. And in this case there > > > really might not be much the user can change in case fo buggy firmware. > > > > Yeah, but introducing new return codes callers might not expected might > > create IMHO other issues. > > > > > Same thing with the WARN - make the potential firmware bug much more > > > obvious and visible. > > > > > > > Yeah, but I doubt this is really necessary. No strong feelings. > > > > Forgot to > > Acked-by: David Hildenbrand <david@xxxxxxxxxx> > Thanks for the review David. I'll change the return code, and keep the WARN, and send a new version.
