Hi Andrew, Thanks for your reply. Perhaps this is a detection rule of Coccinelle (coccicheck) software for programming specifications, and it's no wrong with the code, just a coding style. Best Regards Zou Wei -----邮件原件----- 发件人: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] 发送时间: 2020年4月16日 7:05 收件人: Zouwei (Samuel) <zou_wei@xxxxxxxxxx> 抄送: linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx 主题: Re: [PATCH -next] mm/usercopy: fix warning Comparison to bool On Tue, 14 Apr 2020 11:42:04 +0800 Zou Wei <zou_wei@xxxxxxxxxx> wrote: > fix below warnings reported by coccicheck > > mm/usercopy.c:304:5-18: WARNING: Comparison to bool > > ... > > --- a/mm/usercopy.c > +++ b/mm/usercopy.c > @@ -301,7 +301,7 @@ __setup("hardened_usercopy=", > parse_hardened_usercopy); > > static int __init set_hardened_usercopy(void) { > - if (enable_checks == false) > + if (!enable_checks) > static_branch_enable(&bypass_usercopy_checks); > return 1; > } My initial reaction is "fix coccicheck". There's nothing wrong with that code?
