On Mon, Apr 13, 2020 at 11:02 PM Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> wrote: > > On 4/12/2020 2:09 AM, liliangleo wrote: > > This patch add 'delay_millisecs', 'mini_order', 'batch_size', > > in '/sys/kernel/mm/page_report/'. Usage: > > > > "delay_millisecs": > > Time delay interval between page free and work start to run. > > > > "mini_order": > > Only pages with order equal or greater than mini_order will be > > reported. > > > > "batch_size" > > Wake up the worker only when free pages total size are greater > > than 'batch_size'. > > > > Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx> > > Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> > > Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> > > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > > Cc: Dave Hansen <dave.hansen@xxxxxxxxx> > > Cc: David Hildenbrand <david@xxxxxxxxxx> > > Cc: Michal Hocko <mhocko@xxxxxxxxxx> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Cc: Alex Williamson <alex.williamson@xxxxxxxxxx> > > Signed-off-by: liliangleo <liliangleo@xxxxxxxxxxxxxx> > > I am not really a fan of making these configurable globally. Especially > since the existing virtio-balloon is relying on some of this being > configured the way it is. > > It would make much more sense to push these configuration options out to > the registration interface so that the thing that is registering for > page reporting can configure them when it is registered. > Agree, that's better. Thanks!
