Re: [PATCH v5 15/38] kmsan: x86: disable UNWINDER_ORC under KMSAN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 25, 2020 at 5:13 PM <glider@xxxxxxxxxx> wrote:
>
> KMSAN doesn't currently support UNWINDER_ORC, causing the kernel to
> freeze at boot time.
> See http://github.com/google/kmsan/issues/48.
>
> Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx>
> Cc: Qian Cai <cai@xxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Vegard Nossum <vegard.nossum@xxxxxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: Marco Elver <elver@xxxxxxxxxx>
> Cc: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
>
> ---
> This patch is part of "kmsan: Kconfig changes to disable options
> incompatible with KMSAN", which was split into smaller pieces.
>
> Change-Id: I9cb6ebbaeb9a38e9e1d015c68ab77d40420a7ad0
> ---
>  arch/x86/Kconfig.debug | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index 2e74690b028a5..ad71eb2a416ec 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -276,6 +276,9 @@ choice
>  config UNWINDER_ORC
>         bool "ORC unwinder"
>         depends on X86_64
> +       # KMSAN doesn't support UNWINDER_ORC yet,
> +       # see https://github.com/google/kmsan/issues/48.
> +       depends on !KMSAN

Should we rather make KMSAN depend on !UNWINDER_ORC? It seems more
logical to add this into KMSAN related code, as it's an issue with
KMSAN.

>         select STACK_VALIDATION
>         ---help---
>           This option enables the ORC (Oops Rewind Capability) unwinder for
> --
> 2.25.1.696.g5e7596f4ac-goog
>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux