On Sun, Apr 12, 2020 at 03:35:16PM +0800, chenqiwu wrote: > On Sat, Apr 11, 2020 at 09:10:21AM -0700, Matthew Wilcox wrote: > > On Sat, Apr 11, 2020 at 06:11:56PM +0800, qiwuchen55@xxxxxxxxx wrote: > > > 1) Simplify the code of initializing some variables. > > > - unsigned long scan, total_scan, nr_pages; > > > + unsigned long scan = 0, total_scan = 0, nr_pages; > > > > > > - total_scan = 0; > > > - scan = 0; > > > > I do not find this to be a simplification. > > > Hi willy, > This slightly simplify the code by definition and initialization > meanwhile instead of separating them into the two steps. > This can save two lines of code. And it buries the initialisation on a more complicated line. Number of lines is not the only metric.
