On Sat, Apr 11, 2020 at 3:06 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> But we _have_ an offset_in_page() and it doesn't take a struct page
> argument.
.. it doesn't take a struct page argument because a struct page always
has one compile-time fixed size.
The only reason you seem to want to get the new interface is because
you want to change that fact.
So yes, you'd have to change the _existing_ offset_in_page() to take
that extra "which page" argument.
That's not confusing.
Linus
