Re: [PATCH] slob: push the min alignment to long long

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-06-14 at 22:10 +0200, Sebastian Andrzej Siewior wrote:
> In SLOB ARCH_KMALLOC_MINALIGN is 4 on 32bit platforms by default. On
> powerpc and some other architectures except x86 the default alignment of
> u64 is 8. The leads to __alignof__(struct ipt_entry) being 8 instead of 4
> which is enforced by SLOB.

Ok, so you claim that ARCH_KMALLOC_MINALIGN is not set on some
architectures, and thus SLOB does the wrong thing.

Doesn't that rather obviously mean that the affected architectures
should define ARCH_KMALLOC_MINALIGN? Because, well, they have an
"architecture-specific minimum kmalloc alignment"?

This change will regress SLOB everywhere where '4' was the right answer.

-- 
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]