On Fri, 2011-06-10 at 01:03 +0200, Peter Zijlstra wrote: > The comment in del_consumer() that says: 'drop creation ref' worries me > and makes me thing that is the last reference around and the uprobe will > be freed right there, which clearly cannot happen since its not yet > removed from the RB-tree. I agree about that comment. It scared me too, not only about the RB tree, but the uprobe is used later in that function to drop the write_rwsem. I think that comment needs to be changed to something like: /* Have caller drop the creation ref */ -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>