On Sun, Jun 12, 2011 at 04:24:05PM +0200, Michal Hocko wrote: > On Tue 07-06-11 23:38:14, Minchan Kim wrote: > > acct_isolated of compaction uses page_lru_base_type which returns only > > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. > > In addtion, cc->nr_[anon|file] is used in only acct_isolated so it doesn't have > > fields in conpact_control. > > This patch removes fields from compact_control and makes clear function of > > acct_issolated which counts the number of anon|file pages isolated. > > > > Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > Cc: Mel Gorman <mgorman@xxxxxxx> > > Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx> > > Acked-by: Rik van Riel <riel@xxxxxxxxxx> > > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > Sorry for the late reply. I have looked at the previous posting but No problem. Thanks for the review, Michal. > didn't have time to comment on it. > > Yes, stack usage reduction makes sense and the function also looks more > compact. > > Reviewed-by: Michal Hocko <mhocko@xxxxxxx> > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>