On Wed 01-04-20 08:57:12, Paul E. McKenney wrote: [...] > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index e3ab1c0d9140..8f09cefdfa7b 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -127,6 +127,8 @@ struct vm_area_struct; > > * > > * Reclaim modifiers > > * ~~~~~~~~~~~~~~~~~ > > + * Please note that all the folloging flags are only applicable to sleepable > > s/folloging/following/ Fixed. I will add it on top of http://lkml.kernel.org/r/20200401120502.GH22681@xxxxxxxxxxxxxx and post both later this week to Andrew. >From ce456c2f6c8fe0588c1d743a5b87e283aa4806f8 Mon Sep 17 00:00:00 2001 From: Michal Hocko <mhocko@xxxxxxxx> Date: Wed, 1 Apr 2020 18:02:23 +0200 Subject: [PATCH] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations While it might be really clear to MM developers that gfp reclaim modifiers are applicable only to sleepable allocations (those with __GFP_DIRECT_RECLAIM) it seems that actual users of the API are not always sure. Make it explicit that they are not applicable for GFP_NOWAIT or GFP_ATOMIC allocations which are the most commonly used non-sleepable allocation masks. Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx> --- include/linux/gfp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index e3ab1c0d9140..8040fa944cd8 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -127,6 +127,8 @@ struct vm_area_struct; * * Reclaim modifiers * ~~~~~~~~~~~~~~~~~ + * Please note that all the following flags are only applicable to sleepable + * allocations (e.g. %GFP_NOWAIT and %GFP_ATOMIC will ignore them). * * %__GFP_IO can start physical IO. * -- 2.25.1 -- Michal Hocko SUSE Labs
