On 29.03.20 17:41, Pankaj Gupta wrote: >>> Hi David, >>> >>> Trying to test the series with the Qemu branch(virtio-mem) mentioned. >>> Unfortunately, >>> not able to hotplug memory. Is anything changed from your previous posting >>> or I am doing something wrong? >>> >>> After giving value to "requested-size", I see size as zero. >>> >>> (qemu) qom-set vm0 requested-size 10G >>> (qemu) info memory-devices >>> Memory device [virtio-mem]: "vm0" >>> memaddr: 0x240000000 >>> node: 0 >>> requested-size: 10737418240 >>> size: 0 >>> max-size: 107374182400 >>> block-size: 2097152 >>> memdev: /objects/mem0 >>> >>> Guest kernel: 5.6.0-rc4 >>> Using same Qemu commandline arguments mentioned in cover-letter. >> >> Are you booting from an initrd? Are you compiling virtio-mem as a kernel >> module or into the kernel binary? > Ah was booting into wrong kernel version. Sorry! for the noise. > > Working perfectly for me. Tried various cmbinations for both > hotplug/unplug with multiple > NUMA nodes and verified result in guest. > > For the series, you can add: > Tested-by: Pankaj Gupta <pankaj.gupta.linux@xxxxxxxxx> Awesome, thanks! -- Thanks, David / dhildenb
