Hi Markus, On Sat, Mar 28, 2020 at 12:37 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote: > > Convert the last few remaining mmap_sem rwsem calls to use the new > > mmap locking API. These were missed by coccinelle for some reason > > Will the clarification of this software situation become more interesting? > > > (I think coccinelle does not support some of the preprocessor > > constructs in these files ?) > > I suggest to omit this information from the final change description. > Would you like to help any more to find nicer solutions > for remaining open issues? So, from a practical perspective I think coccinelle has filled its purpose for me - it got 99% of the job done, and I had to do the last 1% by hand which is not ideal, but really not too bad either. Also, by using coccinelle I think reviewers can appreciate that the change is purely mechanical, and reproduce it on their end if needed, which facilitates the review process greatly. I would be interested to find out why coccinelle wasn't able to do the last 1%, but only as part of a long-term learning process on getting better with coccinelle - I don't consider it a blocker for short-term progress on this patchset. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
