On Fri, 10 Jun 2011, Shaohua Li wrote: > On Fri, 2011-06-10 at 06:39 +0800, Hugh Dickins wrote: > > @@ -1492,11 +1460,19 @@ repeat: > > SetPageUptodate(filepage); > > if (sgp == SGP_DIRTY) > > set_page_dirty(filepage); > > + } else { > Looks info->lock unlock is missed here. > Otherwise looks good to me. Many thanks for catching that! Replacements for this patch, and the next which then rejects, follow as replies. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>