On Sat, Mar 21, 2020 at 09:39:02AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:02PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxxxx> > > > > Delete several functions that are never called, fix some desync between > > comments and structure content, remove an unused ret, and move one > > function only used by hmm.c into hmm.c > > This looks good: > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> You mean Reviewed-by? > Btw, the top of file comment in include/linux/hmm.h really needs some > work as well. In fact I think it should be mostly removed with any > remaining useful bit moved to Documentation/vm/hmm.rst. Okay, in v2 I'll just deleted the top, the only thing in this file now is hmm_range_fault() and it can be adaquately described by its kdoc comments. Thanks, Jason
