On Tue, Mar 17, 2020 at 07:55:37PM +0100, Christoph Hellwig wrote: > On Tue, Mar 17, 2020 at 03:38:23PM -0300, Jason Gunthorpe wrote: > > On Mon, Mar 16, 2020 at 02:53:05PM +0100, Christoph Hellwig wrote: > > > Hi Jason, > > > > > > I started looking at bits in my backlog that shouldn't get too much > > > in your way. Here is a bunch of simple patches, on top of the series > > > you sent out. > > > > I applied these two, I made the edits discussed to the last two > > patches, and ran the series over the hmm tester Ralph has. > > > > Please take a quick check: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=2a60cfb32b260468dc81dfc1f56fc0f9ebe9f2e5 > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=ee37d9e6e47439fbd3a72b7c6a13b8ce216fb125 > > > > - Edited commit message to point out that the NONE set is a bug and > > add fixes line. > > - Drop the pfn error and update the commit message, remove now unused > > pfn and i vars > > I wonder if just having those fixes as separate commits would have > been more clear. But the updated patches do look correct to me. Ok, I agree the last one removing the pfns is a bit of overreach, even if the -EPERM exit looks bad when it is de-inlined. I will sort it in a following patch I like the NONE one though So, I swapped the last back to your original I hope to rebase some of my remaining series tomorrow. Things are crazy here right now. https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=ede58c05bec9e5ccf659cf001bb969963806bed0 Thanks, Jason
