On 3/18/20 3:52 PM, Mike Kravetz wrote: > Sounds good. I'll incorporate those changes into a v2, unless someone > else with has a different opinion. > > BTW, this patch should not really change the way the code works today. > It is mostly a movement of code. Unless I am missing something, the > existing code will always allow setup of PMD_SIZE hugetlb pages. Hah, I totally skipped over the old code in the diff. It looks like we'll disable hugetblfs *entirely* if PSE isn't supported. I think this is actually wrong, but nobody ever noticed. I think you'd have to be running as a guest under a hypervisor that's lying about PSE not being supported *and* care about 1GB pages. Nobody does that.