On Tue 17-03-20 12:04:11, Matthew Wilcox wrote: [...] > In fact, since it's only called by those three files, perhaps it should > be in mm/internal.h? I don't see it becoming a terribly popular function > to call outside of the core mm code. Agreed. I do not see any strong reasons why anything outside of the core MM should care about evictability. So if moving it to internal.h is reasonable without too much churn then I would that way. -- Michal Hocko SUSE Labs