Re: [PATCHv2 50/50] kernel: Rename show_stack_loglvl() => show_stack()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on ia64/next linus/master v5.6-rc6 next-20200316]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dmitry-Safonov/Add-log-level-to-show_stack/20200317-080358
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> arch/sparc/kernel/traps_64.c:2455:6: error: conflicting types for 'show_stack'
    2455 | void show_stack(struct task_struct *tsk, unsigned long *_ksp)
         |      ^~~~~~~~~~
   In file included from arch/sparc/kernel/traps_64.c:14:
   include/linux/sched/debug.h:33:13: note: previous declaration of 'show_stack' was here
      33 | extern void show_stack(struct task_struct *task, unsigned long *sp,
         |             ^~~~~~~~~~

vim +/show_stack +2455 arch/sparc/kernel/traps_64.c

^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2454  
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16 @2455  void show_stack(struct task_struct *tsk, unsigned long *_ksp)
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2456  {
c6fee0810df4e0 arch/sparc/kernel/traps_64.c David S. Miller         2011-02-26  2457  	unsigned long fp, ksp;
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2458  	struct thread_info *tp;
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2459  	int count = 0;
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2460  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2461  	int graph = 0;
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2462  #endif
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2463  
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2464  	ksp = (unsigned long) _ksp;
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2465  	if (!tsk)
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2466  		tsk = current;
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2467  	tp = task_thread_info(tsk);
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2468  	if (ksp == 0UL) {
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2469  		if (tsk == current)
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2470  			asm("mov %%fp, %0" : "=r" (ksp));
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2471  		else
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2472  			ksp = tp->ksp;
c1f193a7aed1b4 arch/sparc64/kernel/traps.c  David S. Miller         2007-07-30  2473  	}
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2474  	if (tp == current_thread_info())
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2475  		flushw_all();
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2476  
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2477  	fp = ksp + STACK_BIAS;
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2478  
4fe3ebec122f23 arch/sparc64/kernel/traps.c  David S. Miller         2008-07-17  2479  	printk("Call Trace:\n");
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2480  	do {
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2481  		struct sparc_stackf *sf;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2482  		struct pt_regs *regs;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2483  		unsigned long pc;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2484  
4f70f7a91bffdc arch/sparc64/kernel/traps.c  David S. Miller         2008-08-12  2485  		if (!kstack_valid(tp, fp))
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2486  			break;
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2487  		sf = (struct sparc_stackf *) fp;
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2488  		regs = (struct pt_regs *) (sf + 1);
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2489  
4f70f7a91bffdc arch/sparc64/kernel/traps.c  David S. Miller         2008-08-12  2490  		if (kstack_is_trap_frame(tp, regs)) {
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2491  			if (!(regs->tstate & TSTATE_PRIV))
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2492  				break;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2493  			pc = regs->tpc;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2494  			fp = regs->u_regs[UREG_I6] + STACK_BIAS;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2495  		} else {
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2496  			pc = sf->callers_pc;
14d2c68baa659c arch/sparc64/kernel/traps.c  David S. Miller         2008-05-21  2497  			fp = (unsigned long)sf->fp + STACK_BIAS;
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2498  		}
77c664fa586240 arch/sparc64/kernel/traps.c  David S. Miller         2008-04-24  2499  
4fe3ebec122f23 arch/sparc64/kernel/traps.c  David S. Miller         2008-07-17  2500  		printk(" [%016lx] %pS\n", pc, (void *) pc);
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2501  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2502  		if ((pc + 8UL) == (unsigned long) &return_to_handler) {
945626db0961d8 arch/sparc/kernel/traps_64.c Steven Rostedt (VMware  2018-12-07  2503) 			struct ftrace_ret_stack *ret_stack;
945626db0961d8 arch/sparc/kernel/traps_64.c Steven Rostedt (VMware  2018-12-07  2504) 			ret_stack = ftrace_graph_get_ret_stack(tsk, graph);
945626db0961d8 arch/sparc/kernel/traps_64.c Steven Rostedt (VMware  2018-12-07  2505) 			if (ret_stack) {
945626db0961d8 arch/sparc/kernel/traps_64.c Steven Rostedt (VMware  2018-12-07  2506) 				pc = ret_stack->ret;
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2507  				printk(" [%016lx] %pS\n", pc, (void *) pc);
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2508  				graph++;
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2509  			}
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2510  		}
667f0cee3e0321 arch/sparc/kernel/traps_64.c David S. Miller         2010-04-21  2511  #endif
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2512  	} while (++count < 16);
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2513  }
^1da177e4c3f41 arch/sparc64/kernel/traps.c  Linus Torvalds          2005-04-16  2514  

:::::: The code at line 2455 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux