Hello, On Thu, Jun 02, 2011 at 05:22:42PM +0300, Maxin B John wrote: > > The pool itself is not used there, only the address where the pool > > has been.This will only lead to any trouble if something else is allocated to > > the same place and inserted into the devres list of the same device between > > the dma_pool_destroy() and devres_destroy(). Which can't happen. devres release is bound to device driver model and a device can't be re-attached before release is complete. ie. those operations are serialized, so the failure mode is only theoretical. > Thank you very much for explaining it in detail. > > > But I agree that this is bad style. But if you are going to change > > this please also have a look at devm_iounmap() in lib/devres.c. Maybe also the > > devm_*irq* functions need the same changes. > > As per your suggestion, I have made similar modifications for lib/devres.c and > kernel/irq/devres.c > > CCed the maintainers of the respective files. > > Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx> But it shouldn't hurt and if it helps memleak. Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>