> On Mar 3, 2020, at 2:47 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > or maybe it's a good reason to make hpage_nr_pages() check that > assertion if !CONFIG_TRANSPARENT_HUGEPAGE. That would be easy enough to do as at present if !CONFIG_TRANSPARENT_HUGEPAGE, hpage_nr_pages() simply returns 1. It would give more coverage to the assert at the cost of a slight performance degradation. Do you think it would be worth it?