On 2020-03-04 09:19:21 [+0100], Vlastimil Babka wrote: > >> + WARN_ONCE(old != *(int *)table->data, "sysctl attribute %s changed.", > >> + table->procname); > > > > The WARN will include a stack trace which just isn't interesting. A > > pr_warn() would be better? > > Yeah, the only interesting part of full WARN would possibly be, which process > changed it. That might be useful to print. Yes, the stack trace and register dump isn't interesting. But as Vlastimil says, the task and pid are informative. So if that is too much I could extract those two informations and include it in a pr_warn(). Sebastian
