On Mon, 2020-03-02 at 10:42 -0800, Dan Williams wrote: > On Mon, Mar 2, 2020 at 9:59 AM Frederic Barrat <fbarrat@xxxxxxxxxxxxx > > wrote: > > > > > > Le 21/02/2020 à 04:27, Alastair D'Silva a écrit : > > > From: Alastair D'Silva <alastair@xxxxxxxxxxx> > > > > > > Similar to the previous patch, this adds support for near storage > > > commands. > > > > > > Signed-off-by: Alastair D'Silva <alastair@xxxxxxxxxxx> > > > --- > > > > Is any of these new functions ever called? > > This is my concern as well. The libnvdimm command support is limited > to the commands that Linux will use. Other passthrough commands are > supported through a passthrough interface. However, that passthrough > interface is explicitly limited to publicly documented command sets > so > that the kernel has an opportunity to constrain and consolidate > command implementations across vendors. It will be in the patch that implements overwrite. I moved that patch out of this series, as it needs more testing, so I guess I can submit this alongside it. -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819