Re: [PATCH] mm/swap: annotate data races for lru_rotate_pvecs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Feb 2020 at 12:30, Qian Cai <cai@xxxxxx> wrote:
>
>
>
> > On Feb 28, 2020, at 5:49 AM, Marco Elver <elver@xxxxxxxxxx> wrote:
> >
> > Note that, the fact that the writer has local interrupts disabled for
> > the write is irrelevant because it's the interrupt that triggered
> > while the read was happening that led to the concurrent write.
>
> I was just to explain that concurrent writers are rather unlikely as people may ask.
>
> >
> > I assume you ran this with CONFIG_KCSAN_INTERRUPT_WATCHER=y?  The
> > option is disabled by default (see its help-text). I don't know if we
> > want to deal with data races due to interrupts right now, especially
> > those that just result in 'data_race' annotations. Thoughts?
>
> Yes, I somehow got quite a bit clean runs lately thanks to the fix/annotations efforts for the last a few weeks (still struggling with the flags things a bit), so I am naturally expanding the testing coverage here.
>
> Right now the bottleneck is rather some subsystem maintainers are not so keen to deal with data races (looking forward to seeing more education opportunities for all), but the MM subsystem is not one of them.

Sounds reasonable.  FWIW

Acked-by: Marco Elver <elver@xxxxxxxxxx>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux