On 02/26/2020 05:04 PM, Vlastimil Babka wrote: > On 2/26/20 5:50 AM, Anshuman Khandual wrote: >> Move VM_NO_KHUGEPAGED into generic header (include/linux/mm.h). This just >> makes sure that no VMA flag is scattered in individual function files any >> longer. While at this, fix an old comment which is no longer valid. >> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: linux-mm@xxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> >> --- >> include/linux/mm.h | 3 ++- >> mm/khugepaged.c | 2 -- >> 2 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 52269e56c514..6f7e400e6ea3 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -287,6 +287,8 @@ extern unsigned int kobjsize(const void *objp); >> #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */ >> #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */ >> >> +#define VM_NO_KHUGEPAGED (VM_SPECIAL | VM_HUGETLB) > > While the preprocessor doesn't mind that VM_SPECIAL is only defined later, I > would have moved this below VM_SPECIAL definition anyway, where it fits better, > and add a comment like other defines there do? Sure, will do.
