On Wed, Feb 19, 2020 at 01:00:40PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > The readahead code is part of the page cache so should be found in the > pagemap.h file. force_page_cache_readahead is only used within mm, > so move it to mm/internal.h instead. Remove the parameter names where > they add no value, and rename the ones which were actively misleading. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>