Hi Scott, I love your patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on kselftest/next linus/master v5.6-rc2] [cannot apply to driver-core/driver-core-testing next-20200221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200222-032851 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 06e33595e96f212811066df192ae8bf802174296 config: x86_64-randconfig-c002-20200221 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/base/firmware_loader/fallback.h:5:0, from drivers/base/firmware_loader/fallback_table.c:12: >> include/linux/firmware.h:97:1: error: expected identifier or '(' before '{' token { ^ include/linux/firmware.h:94:19: warning: 'request_firmware_into_buf' declared 'static' but never defined [-Wunused-function] static inline int request_firmware_into_buf(const struct firmware **firmware_p, ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +97 include/linux/firmware.h fbab976d7ce455 James Bottomley 2008-03-07 93 a098ecd2fa7db8 Stephen Boyd 2016-08-02 94 static inline int request_firmware_into_buf(const struct firmware **firmware_p, 6f0a3d616d978b Scott Branden 2020-02-19 95 const char *name, struct device *device, void *buf, size_t size, 6f0a3d616d978b Scott Branden 2020-02-19 96 size_t offset, unsigned int pread_flags); a098ecd2fa7db8 Stephen Boyd 2016-08-02 @97 { a098ecd2fa7db8 Stephen Boyd 2016-08-02 98 return -EINVAL; a098ecd2fa7db8 Stephen Boyd 2016-08-02 99 } a098ecd2fa7db8 Stephen Boyd 2016-08-02 100 :::::: The code at line 97 was first introduced by commit :::::: a098ecd2fa7db8fa4fcc178a43627b29b226edb9 firmware: support loading into a pre-allocated buffer :::::: TO: Stephen Boyd <stephen.boyd@xxxxxxxxxx> :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
