On Fri, Feb 21, 2020 at 8:21 AM Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > > On Thu, Feb 20, 2020 at 7:28 PM Alastair D'Silva <alastair@xxxxxxxxxxx> wrote: > > > > From: Alastair D'Silva <alastair@xxxxxxxxxxx> > > > > This series adds support for OpenCAPI Persistent Memory devices, exposing > > them as nvdimms so that we can make use of the existing infrastructure. > > A single sentence to introduce: > > 24 files changed, 3029 insertions(+), 97 deletions(-) > > ...is inadequate. What are OpenCAPI Persistent Memory devices? How do > they compare, in terms relevant to libnvdimm, to other persistent > memory devices? What challenges do they pose to the existing enabling? > What is the overall approach taken with this 27 patch break down? What > are the changes since v2, v1? If you incorporated someone's review > feedback note it in the cover letter changelog, if you didn't Assumptions and tradeoffs the implementation considered are also critical for reviewing the approach.
