Hi, Mel, Thanks a lot for your review! Mel Gorman <mgorman@xxxxxxx> writes: > On Tue, Feb 18, 2020 at 04:26:28PM +0800, Huang, Ying wrote: >> From: Huang Ying <ying.huang@xxxxxxxxx> >> >> In autonuma memory tiering mode, the hot PMEM (persistent memory) >> pages could be migrated to DRAM via autonuma. But this incurs some >> overhead too. So that sometimes the workload performance may be hurt. >> To avoid too much disturbing to the workload, the migration throughput >> should be rate-limited. >> >> At the other hand, in some situation, for example, some workloads >> exits, many DRAM pages become free, so that some pages of the other >> workloads can be migrated to DRAM. To respond to the workloads >> changing quickly, it's better to migrate pages faster. >> >> To address the above 2 requirements, a rate limit algorithm as follows >> is used, >> >> - If there is enough free memory in DRAM node (that is, > high >> watermark + 2 * rate limit pages), then NUMA migration throughput will >> not be rate-limited to respond to the workload changing quickly. >> >> - Otherwise, counting the number of pages to try to migrate to a DRAM >> node via autonuma, if the count exceeds the limit specified by the >> users, stop NUMA migration until the next second. >> >> A new sysctl knob kernel.numa_balancing_rate_limit_mbps is added for >> the users to specify the limit. If its value is 0, the default >> value (high watermark) will be used. >> >> TODO: Add ABI document for new sysctl knob. >> > > I very strongly suggest that this only be done as a last resort and with > supporting data as to why it is necessary. NUMA balancing did have rate > limiting at one point and it was removed when balancing was smart enough > to mostly do the right thing without rate limiting. I posted a series > that reconciled NUMA balancing with the CPU load balancer recently which > further reduced spurious and unnecessary migrations. I would not like > to see rate limiting reintroduced unless there is no other way of fixing > saturation of memory bandwidth due to NUMA balancing. Even if it's > needed as a stopgap while the feature is finalised, it should be > introduced late in the series explaining why it's temporarily necessary. This adds rate limit to NUMA migration between the different types of memory nodes only (e.g. from PMEM to DRAM), but not between the same types of memory nodes (e.g. from DRAM to DRAM). Sorry for confusing patch subject. I will change it in the next version. And, rate limit is an inherent part of the algorithm used in the patchset. Because we just use LRU algorithm to find the cold pages on the fast memory node (e.g. DRAM), and use NUMA hint page fault latency to find the hot pages on the slow memory node (e.g. PMEM). But we don't compare the temperature between the cold DRAM pages and the hot PMEM pages. Instead, we just try to exchange some cold DRAM pages and some hot PMEM pages, even if the cold DRAM pages is hotter than the hot PMEM pages. The rate limit is used to control how many pages to exchange between DRAM and PMEM per second. This isn't perfect, but it works well in our testing. Best Regards, Huang, Ying
